Warn when DDNoopRUMMonitor is sent any DDRUMMonitor methods#1007
Merged
Conversation
Contributor
Author
|
I could use help understanding what about the Bitrise job failed – I don't have permissions to view the failure message, and the unit test I updated succeeds on my machine. |
maxep
reviewed
Sep 21, 2022
maxep
left a comment
maxep
left a comment
Member
There was a problem hiding this comment.
Hey @dfed ! Thank you so much for this contribution 👍
Indeed, our CI requires a manual trigger before running external PRs. It looks great, only the linter is failing because of that extra line break. After that, it would be good for merging.
Thanks again!
Co-authored-by: Maxime Epain <[email protected]>
maxep
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
This PR resolves the baseline request in #978 by calling
warn()when any method vended byDDRUMMonitoris called on an instance ofDDNoopRUMMonitor.This change will make it more obvious when a
DDNoopRUMMonitorhas been captured and is being utilized accidentally.How?
I copied over all methods from
DDRUMMonitorintoDDNoopRUMMonitor, replacedpublicwithoverride, and calledwarn()within each method body.Review checklist
Custom CI job configuration (optional)