Small fix in the PokoGenerator tool#989
Merged
Merged
Conversation
0xnm
approved these changes
Jul 20, 2022
| ).firstOrNull { it != null } | ||
| if (result == null) { | ||
| val message = "Unable to parse json into one of type Animal\n" + | ||
| val message = "Unable to parse json into one of type \n" + "Animal\n" + |
Member
There was a problem hiding this comment.
do we need an additional line break?
Member
Author
There was a problem hiding this comment.
Yes, in some of the schemas for Session Replay we have longer class names and it breaks when Kotlin Poet wraps the line.
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #989 +/- ##
=================================================
+ Coverage 82.63% 82.83% +0.20%
=================================================
Files 296 295 -1
Lines 9777 9714 -63
Branches 1617 1590 -27
=================================================
- Hits 8079 8046 -33
+ Misses 1214 1188 -26
+ Partials 484 480 -4
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the constant field generator in the PokoGenerator for Json schemas.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)