RUMM-2330 Generate Session Replay modes based on the JSON schemas#986
Merged
mariusc83 merged 1 commit intoJul 22, 2022
Conversation
mariusc83
force-pushed
the
feature/session-replay-vo
branch
from
July 19, 2022 14:50
3e96e13 to
b87afe0
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2265/create-json-schemas-for-session-replay
branch
2 times, most recently
from
July 19, 2022 15:39
ce9c9e5 to
189ba55
Compare
mariusc83
changed the title
mariusc83
force-pushed
the
mconstantin/rumm-2265/create-json-schemas-for-session-replay
branch
from
July 20, 2022 09:22
189ba55 to
a804481
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #986 +/- ##
============================================================
Coverage ? 82.85%
============================================================
Files ? 298
Lines ? 9772
Branches ? 1595
============================================================
Hits ? 8096
Misses ? 1195
Partials ? 481 |
mariusc83
marked this pull request as ready for review
July 20, 2022 11:26
0xnm
approved these changes
Jul 20, 2022
mariusc83
force-pushed
the
feature/session-replay-vo
branch
from
July 20, 2022 11:50
b87afe0 to
1b47219
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2265/create-json-schemas-for-session-replay
branch
from
July 20, 2022 11:50
a804481 to
a706184
Compare
xgouchet
approved these changes
Jul 20, 2022
buraizu
requested changes
Jul 20, 2022
buraizu
left a comment
buraizu
left a comment
Contributor
There was a problem hiding this comment.
Thanks, made some suggestions per our contributing guidelines
mariusc83
force-pushed
the
mconstantin/rumm-2265/create-json-schemas-for-session-replay
branch
from
July 20, 2022 19:11
50af5a5 to
f175f09
Compare
buraizu
approved these changes
Jul 21, 2022
buraizu
left a comment
buraizu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for implementing those changes, and apologies, as it looks like I missed one minor point. Made a new suggestion, but otherwise LGTM
| "properties": { | ||
| "has_focus": { | ||
| "type": "boolean", | ||
| "description": "Whether this screen has a focus or not. For now it will always be true for mobile.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "Whether this screen has a focus or not. For now it will always be true for mobile.", | |
| "description": "Whether this screen has a focus or not. For now it is always true for mobile.", |
mariusc83
deleted the
mconstantin/rumm-2265/create-json-schemas-for-session-replay
branch
July 22, 2022 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are adding the necessary gradle tasks to the
library:dd-sdk-android-session-replaymodule to be able to generate the required Session Replay Pokos based on the JSON schemas defined in the : Rum Events Format Repository.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)