RUMM-2335 Add Session Replay Public API tests#985
Merged
mariusc83 merged 1 commit intoJul 15, 2022
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
3 times, most recently
from
July 13, 2022 15:33
808b3eb to
149b7aa
Compare
mariusc83
marked this pull request as ready for review
July 13, 2022 15:34
mariusc83
force-pushed
the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
2 times, most recently
from
July 13, 2022 16:18
4047334 to
8ccd839
Compare
0xnm
approved these changes
Jul 15, 2022
mariusc83
force-pushed
the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
from
July 15, 2022 07:28
8ccd839 to
0ddd1c1
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #985 +/- ##
============================================================
Coverage ? 82.70%
============================================================
Files ? 299
Lines ? 9835
Branches ? 1622
============================================================
Hits ? 8134
Misses ? 1216
Partials ? 485 |
mariusc83
deleted the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
July 15, 2022 11:11
mariusc83
restored the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
July 21, 2022 12:24
mariusc83
deleted the
mconstantin/rumm-2335/add-session-replay-public-api-unit-tests
branch
July 21, 2022 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are adding the unit tests for the Public API of Session Replay feature.
Please not that the nightly tests coverage was dropped to 0.90 due to the newly introduced 2 methods. These will be covered later in another PR once Session Replay alpha will be ready.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)