RUMM-2324: Let user to disable RUM view tracking strategy#981
Merged
0xnm merged 2 commits intoJul 13, 2022
Merged
Conversation
mariusc83
reviewed
Jul 12, 2022
| fun trackInteractions(Array<com.datadog.android.rum.tracking.ViewAttributesProvider> = emptyArray(), com.datadog.android.rum.tracking.InteractionPredicate = NoOpInteractionPredicate()): Builder | ||
| fun trackLongTasks(Long = DEFAULT_LONG_TASK_THRESHOLD_MS): Builder | ||
| fun useViewTrackingStrategy(com.datadog.android.rum.tracking.ViewTrackingStrategy): Builder | ||
| fun useViewTrackingStrategy(com.datadog.android.rum.tracking.ViewTrackingStrategy?): Builder |
Member
There was a problem hiding this comment.
should we do this or should we have it null by default in the configuration and have this method as before ?
Member
Author
There was a problem hiding this comment.
I think we should have it ActivityViewTrackingStrategy in the configuration by default, to ease onboarding.
Codecov Report
@@ Coverage Diff @@
## develop #981 +/- ##
===========================================
- Coverage 83.08% 83.05% -0.03%
===========================================
Files 268 268
Lines 9213 9213
Branches 1484 1484
===========================================
- Hits 7654 7651 -3
- Misses 1151 1153 +2
- Partials 408 409 +1
|
mariusc83
approved these changes
Jul 12, 2022
0xnm
deleted the
nogorodnikov/rumm-2324/let-user-disable-view-tracking-strategy
branch
July 13, 2022 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change allows user to disable the default view tracking strategy if there is a need/wish to do view tracking manually by using
RumMonitoron the user side.This is achieved by letting call
Configuration#useViewTrackingStrategywithnullargument, which will make SDK useNoOpViewTrackingStrategy.Review checklist (to be filled by reviewers)