RUMM-2322: Report back interaction as back type, prevent reporting empty target name#980
Merged
0xnm merged 1 commit intoJul 15, 2022
Conversation
mariusc83
approved these changes
Jul 12, 2022
Codecov Report
@@ Coverage Diff @@
## develop #980 +/- ##
===========================================
- Coverage 83.08% 83.06% -0.02%
===========================================
Files 268 268
Lines 9213 9216 +3
Branches 1484 1485 +1
===========================================
+ Hits 7654 7655 +1
- Misses 1151 1153 +2
Partials 408 408
|
xgouchet
suggested changes
Jul 13, 2022
| customTargetName | ||
| } | ||
| GlobalRum.get().addUserAction(RumActionType.CUSTOM, targetName, emptyMap()) | ||
| GlobalRum.get().addUserAction(RumActionType.TAP, targetName, emptyMap()) |
Contributor
There was a problem hiding this comment.
This interaction is handleBackEvent, and there's a BACK type for actions, maybe we should use that instead as it more precise
Member
Author
There was a problem hiding this comment.
thanks! I didn't know back type exists in the RUM schema. I've updated my PR.
0xnm
force-pushed
the
nogorodnikov/rumm-2322/improve-interaction-tracking-reporting
branch
from
July 13, 2022 07:21
350f96f to
1bf0723
Compare
0xnm
changed the title
xgouchet
approved these changes
Jul 15, 2022
0xnm
deleted the
nogorodnikov/rumm-2322/improve-interaction-tracking-reporting
branch
July 15, 2022 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change does the following:
backinteraction are reported asBACKnow insteadCUSTOM.onUpis not called, because screen is closed while finger is still touching the screen. To avoid that we will reporttargetIdandtargetNamefor thestartUserActionas well, so that once it completes due to timeout, it has the necessary data.Fixes #964.
Review checklist (to be filled by reviewers)