Skip to content

RUMM-2315 Add support to Json Schema's oneOf syntax#976

Merged
xgouchet merged 3 commits into
feature/sdkv2from
xgouchet/RUMM-2315/poko_inheritance
Jul 19, 2022
Merged

RUMM-2315 Add support to Json Schema's oneOf syntax#976
xgouchet merged 3 commits into
feature/sdkv2from
xgouchet/RUMM-2315/poko_inheritance

Conversation

@xgouchet

@xgouchet xgouchet commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This adds support to the oneOf option of JsonSchema which maps to a sealed class.

Additional Notes

Did a bit of refactoring and ensured the tests ran on all types.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@xgouchet
xgouchet requested a review from a team as a code owner July 8, 2022 10:13
@xgouchet
xgouchet changed the base branch from develop to feature/sdkv2 July 8, 2022 10:13
mariusc83
mariusc83 approved these changes Jul 8, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xnm
0xnm reviewed Jul 8, 2022
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! I've left few questions, but overall looks good.

Comment thread buildSrc/src/main/kotlin/com/datadog/gradle/plugin/jsonschema/JsonSchemaReader.kt
Comment thread buildSrc/src/test/kotlin/com/example/model/Animal.kt Outdated
Comment thread buildSrc/src/test/kotlin/com/datadog/android/core/internal/utils/MiscUtils.kt
mariusc83
mariusc83 requested changes Jul 11, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some use - cases that are failing now.

mariusc83
mariusc83 requested changes Jul 11, 2022
View reviewed changes
Comment thread ...src/main/kotlin/com/datadog/gradle/plugin/jsonschema/generator/ClassDeserializerGenerator.kt
Comment thread buildSrc/src/main/kotlin/com/datadog/gradle/plugin/jsonschema/generator/KotlinSpecGenerator.kt Outdated
@xgouchet
xgouchet force-pushed the xgouchet/RUMM-2315/poko_inheritance branch from 633bbd6 to 2063204 Compare July 17, 2022 10:47
@xgouchet
xgouchet requested review from 0xnm and mariusc83 July 17, 2022 10:48
@xgouchet xgouchet added the size-huge This PR is huge sized label Jul 17, 2022
@xgouchet
xgouchet force-pushed the xgouchet/RUMM-2315/poko_inheritance branch from 2063204 to 994edf1 Compare July 17, 2022 12:25
mariusc83
mariusc83 approved these changes Jul 18, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !! LGTM now !!

0xnm
0xnm approved these changes Jul 18, 2022
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good job!

@xgouchet
xgouchet merged commit a566e0f into feature/sdkv2 Jul 19, 2022
@xgouchet
xgouchet deleted the xgouchet/RUMM-2315/poko_inheritance branch July 19, 2022 13:09
@0xnm 0xnm mentioned this pull request Jul 25, 2022
Merged
3 tasks
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

size-huge This PR is huge sized

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@xgouchet @mariusc83 @0xnm