RUMM-2267 Add Session Replay public API #974
Conversation
eda61b7 to
1dfdc06
Compare
31fa4de to
1936ced
Compare
1936ced to
b40943b
Compare
| } | ||
|
|
||
| dependencies { | ||
| api(project(":library:dd-sdk-android-session-replay")) |
There was a problem hiding this comment.
I think it shouldn't be here, core module shouldn't depend on the feature module
There was a problem hiding this comment.
Following the current architecture I was not able to do it differently. I need to be able to inject the SessionReplayActivityLifecycleHook from the SessionReplayFeature. If you want we can have a chat about this maybe we can find a solution to do it differently.
There was a problem hiding this comment.
The idea is that later the dependency will change (will be the other way around) once we provide the SDK V2 feature initialization. Have in mind that besides this code all the other Session Replay code will leave in the session replay module and will be easy for us to decouple later.
| TRACE("Tracing"), | ||
| RUM("RUM") | ||
| RUM("RUM"), | ||
| SESSION_REPLAY(featureName = "Session Replay") |
There was a problem hiding this comment.
| SESSION_REPLAY(featureName = "Session Replay") | |
| SESSION_REPLAY("Session Replay") |
b40943b to
97761af
Compare
4 participants
What does this PR do?
This PR adds the Session Replay Feature and Public API in the
dd-sdk-androidmodule.Note:
feature/sdkv2branch the unit tests could not be added as we are waiting for thefeature/sdkv2tests to be fixed first. A new task was added in the backlog for adding the necessary tests when the time comes.library/dd-sdk-android-session-replaymodule.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)