Skip to content

RUMM-1876: Support calls with implicit receiver in UnsafeThirdPartyFunctionCall check#970

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-1876/support-calls-with-implicit-receiver-in-UnsafeThirdPartyFunctionCall-check
Jul 4, 2022
Merged

RUMM-1876: Support calls with implicit receiver in UnsafeThirdPartyFunctionCall check#970
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-1876/support-calls-with-implicit-receiver-in-UnsafeThirdPartyFunctionCall-check

Conversation

@0xnm

@0xnm 0xnm commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This change brings support of the 3rd party calls with implicit receiver, such as:

fun test(f: File): Any {
    return with(f) { inputStream() }
}

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner July 1, 2022 08:48
@xgouchet xgouchet added the size-small This PR is small sized label Jul 1, 2022
xgouchet
xgouchet approved these changes Jul 1, 2022
View reviewed changes

@xgouchet xgouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@0xnm
0xnm merged commit c0cb2f0 into develop Jul 4, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-1876/support-calls-with-implicit-receiver-in-UnsafeThirdPartyFunctionCall-check branch July 4, 2022 08:52
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-small This PR is small sized

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @xgouchet @mariusc83