Skip to content

Android and Android TV Monitoring Formatting Edit#966

Merged
alai97 merged 4 commits into
masterfrom
alai97/fixing-code-snippet-spacing
Jul 20, 2022
Merged

Android and Android TV Monitoring Formatting Edit#966
alai97 merged 4 commits into
masterfrom
alai97/fixing-code-snippet-spacing

Conversation

@alai97

@alai97 alai97 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Small spacing nits.

Motivation

Batch edit for Error Tracking.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@alai97
alai97 requested review from a team as code owners June 29, 2022 23:53
@codecov-commenter

codecov-commenter commented Jun 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #966 (158e017) into master (fab5eb6) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   83.09%   83.03%   -0.07%     
==========================================
  Files         267      267              
  Lines        9086     9079       -7     
  Branches     1465     1461       -4     
==========================================
- Hits         7550     7538      -12     
- Misses       1135     1139       +4     
- Partials      401      402       +1
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 96.08% <0.00%> (-3.92%) ⬇️
...nternal/persistence/file/batch/BatchFileHandler.kt 78.30% <0.00%> (-2.83%) ⬇️
...com/datadog/android/compose/InteractionTracking.kt 73.55% <0.00%> (-2.31%) ⬇️
...tadog/android/tv/LeanbackViewAttributesProvider.kt 84.21% <0.00%> (-2.00%) ⬇️
.../datadog/android/rum/webview/RumWebChromeClient.kt 80.00% <0.00%> (-1.48%) ⬇️
.../android/rum/internal/tracking/ViewLoadingTimer.kt 93.33% <0.00%> (-0.22%) ⬇️
.../com/datadog/android/tracing/TracingInterceptor.kt 97.78% <0.00%> (-0.06%) ⬇️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 95.83% <0.00%> (-0.03%) ⬇️
...kotlin/com/datadog/android/DatadogEventListener.kt 98.48% <0.00%> (-0.02%) ⬇️
... and 9 more

xgouchet
xgouchet suggested changes Jun 30, 2022
View reviewed changes
Comment thread docs/rum_getting_started.md Outdated
alai97
alai97 commented Jun 30, 2022
View reviewed changes
Comment thread docs/rum_getting_started.md Outdated
Comment thread docs/rum_getting_started.md Outdated
@alai97
alai97 requested a review from xgouchet June 30, 2022 21:45
hestonhoffman
hestonhoffman approved these changes Jul 1, 2022
View reviewed changes

@hestonhoffman hestonhoffman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but LGTM

Comment thread docs/rum_getting_started.md Outdated
@alai97
alai97 merged commit c3138f4 into master Jul 20, 2022
@alai97
alai97 deleted the alai97/fixing-code-snippet-spacing branch July 20, 2022 01:05
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@hestonhoffman hestonhoffman hestonhoffman approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@alai97 @codecov-commenter @xgouchet @0xnm @hestonhoffman