Skip to content

Syncing Changes from Develop to Master#965

Merged
alai97 merged 20 commits into
developfrom
master
Jul 19, 2022
Merged

Syncing Changes from Develop to Master#965
alai97 merged 20 commits into
developfrom
master

Conversation

@alai97

@alai97 alai97 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Syncing doc updates from master into develop, which is the default GitHub branch.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@alai97
alai97 requested review from a team as code owners June 29, 2022 20:16
@codecov-commenter

codecov-commenter commented Jun 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #965 (fab5eb6) into develop (a929906) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
- Coverage    83.19%   83.09%   -0.10%     
===========================================
  Files          267      267              
  Lines         9086     9086              
  Branches      1465     1465              
===========================================
- Hits          7559     7550       -9     
- Misses        1129     1135       +6     
- Partials       398      401       +3     
Impacted Files Coverage Δ
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 83.33% <0.00%> (-5.17%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 82.61% <0.00%> (-4.35%) ⬇️
...al/persistence/file/batch/BatchFileOrchestrator.kt 92.93% <0.00%> (-2.02%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 94.48% <0.00%> (ø)
...nternal/persistence/file/batch/BatchFileHandler.kt 81.13% <0.00%> (+2.83%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (+10.00%) ⬆️

@xgouchet xgouchet added the size-medium This PR is medium sized label Jun 29, 2022

### Initialize the library with application context

In the initialization snippet, set an environment name, service name, and version number. In the examples below, `APP_VARIANT_NAME` specifies the name of the service that generates data. For more information, see [Using Tags][14].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APP Variant name specifies the variant of the app, not the name of the service

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the initialization snippet, set an environment name, service name, and version number. In the examples below, `APP_VARIANT_NAME` specifies the name of the service that generates data. For more information, see [Using Tags][14].
In the initialization snippet, set an environment name, service name, and version number. In the examples below, `APP_VARIANT_NAME` specifies the variant of the application that generates data. For more information, see [Using Tags][14].

@alai97
alai97 merged commit 588b6a5 into develop Jul 19, 2022
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-medium This PR is medium sized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants