RUMM-2208: SDK v2 upload pipeline#956
Merged
0xnm merged 1 commit intoJun 24, 2022
Merged
Conversation
0xnm
marked this pull request as ready for review
June 22, 2022 09:20
xgouchet
suggested changes
Jun 22, 2022
mariusc83
approved these changes
Jun 22, 2022
xgouchet
approved these changes
Jun 23, 2022
0xnm
force-pushed
the
nogorodnikov/rumm-2208/sdk-v2-upload-pipeline
branch
from
June 24, 2022 07:00
4d3eb64 to
ad334e5
Compare
0xnm
force-pushed
the
nogorodnikov/rumm-2208/sdk-v2-upload-pipeline
branch
from
June 24, 2022 07:17
ad334e5 to
915dc30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change brings the foundation of the upload pipeline for SDK v2 which is using a single
Storageconcept introduced before (meaning pipeline also leverages batch metadata).In the nutshell upload job will read the batch available for the upload via
Storage#readNextBatchcall and will pass the batch and its metadata (if exists) to the uploader, which knows a) how to create a request (responsibility of the feature); b) how to execute it (responsibility of the SDK).Most of the changes are done in the
UploadWorker,DataOkHttpUploader,DataUploadRunnableclasses (the last 2 are the copies of the v1 classes residing in the v2 package, this is done in order to avoid big changes in theSdkFeature, which will be done later).Note, that this change doesn't yet support
1:manyrelationship between batch and requests created, this will be done in another task(s).Review checklist (to be filled by reviewers)