Skip to content

RUMM-2263 Setup dd-sdk-android-session-replay module#953

Merged
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2263/setup-project-for-session-replay
Jun 22, 2022
Merged

RUMM-2263 Setup dd-sdk-android-session-replay module#953
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2263/setup-project-for-session-replay

Conversation

@mariusc83

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
mariusc83 requested a review from a team as a code owner June 20, 2022 14:41
@mariusc83 mariusc83 self-assigned this Jun 20, 2022
@mariusc83
mariusc83 requested a review from a team as a code owner June 20, 2022 14:41

@kayayarai kayayarai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review needed

@0xnm

0xnm commented Jun 21, 2022

Copy link
Copy Markdown
Member

Seems like this PR has SDK v2 as a base, which has tests broken. Shouldn't we use develop branch (SDK v1) for the project scaffolding?

@mariusc83
mariusc83 merged commit c37617f into feature/session-replay-vo Jun 22, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2263/setup-project-for-session-replay branch June 22, 2022 07:49
@xgouchet xgouchet added this to the internal milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants