Conversation
ghost
self-requested a review
as a code owner
June 17, 2022 16:14
ghost
mentioned this pull request
xgouchet
suggested changes
Jun 20, 2022
Contributor
|
Thanks a lot for this PR, I added a few comments to ensure consistency with our guidelines and existing APIs |
Author
|
feedback should be addressed! |
ghost
requested a review
from xgouchet
June 20, 2022 12:50
xgouchet
suggested changes
Jun 21, 2022
xgouchet
left a comment
xgouchet
left a comment
Contributor
There was a problem hiding this comment.
Just a few nit picks regarding property based testing. Also can you make sure that the static analysis pass locally:
./gradlew clean detektAll ktlintCheckAll lintCheckAll
Author
|
Verified static analysis passed locally 👍 I did run into this issue though (https://issuetracker.google.com/issues/206099937) - I upgraded the AGP version to 7.2.1 locally and that worked for me (and reverted before committing) Other feedback should be addressed as well |
ghost
requested a review
from xgouchet
June 21, 2022 12:01
xgouchet
approved these changes
Jun 21, 2022
Author
|
@xgouchet ty for merging 🙏 are you able to share when we might see this in a release for the SDK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a method to set the additional properties on a user
issue raised here: #950
Motivation
Throughout our application, we have properties that we want to set at a point where it'd be inconvenient to also have to grab the user's name / email / id. being able to set properties on the fly for a user is a convenient method that exists in multiple other logging types of libraries / SDKs
Additional Notes
I wasn't able to get the sample project running on my M1 device (issue opened #951) - but I did add a call site to it. Please let me know if there is more documentation / usage that should be added!
Review checklist (to be filled by reviewers)