Skip to content

Don't report telemetry for unknown web events#940

Merged
0xnm merged 1 commit into
release/1.13.0from
nogorodnikov/dont-report-telemetry-for-unknown-web-event
May 30, 2022
Merged

Don't report telemetry for unknown web events#940
0xnm merged 1 commit into
release/1.13.0from
nogorodnikov/dont-report-telemetry-for-unknown-web-event

Conversation

@0xnm

@0xnm 0xnm commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Remove telemetry reporting for unknown web events, because Browser SDK can be way ahead of Android SDK.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner May 27, 2022 09:13
xgouchet
xgouchet approved these changes May 27, 2022
View reviewed changes

@xgouchet xgouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're there, we have a lot of UnknownHostException telemetry errors from Khronos, maybe we can mute those too, wdyt?

@0xnm

0xnm commented May 27, 2022

Copy link
Copy Markdown
Member Author

@xgouchet UnknownHostException is already filtered out, seems we just have apps which are not on rc1 yet.

@codecov-commenter

codecov-commenter commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #940 (1277e0d) into release/1.13.0 (961e0dc) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release/1.13.0     #940      +/-   ##
==================================================
- Coverage           83.28%   83.17%   -0.11%     
==================================================
  Files                 267      267              
  Lines                9086     9086              
  Branches             1465     1465              
==================================================
- Hits                 7567     7557      -10     
- Misses               1122     1129       +7     
- Partials              397      400       +3
Impacted Files Coverage Δ
...roid/webview/internal/MixedWebViewEventConsumer.kt 100.00% <100.00%> (ø)
...ndroid/core/internal/persistence/file/EventMeta.kt 70.00% <0.00%> (-20.00%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.36% <0.00%> (-1.15%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.84%) ⬇️

@0xnm
0xnm merged commit 3bcc8e4 into release/1.13.0 May 30, 2022
@0xnm
0xnm deleted the nogorodnikov/dont-report-telemetry-for-unknown-web-event branch May 30, 2022 07:59
@xgouchet xgouchet added this to the 1.13.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83