Android Advanced Configuration Edits#938
Merged
Merged
Conversation
alai97
reviewed
May 26, 2022
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
===========================================
+ Coverage 82.86% 82.92% +0.07%
===========================================
Files 265 265
Lines 9035 9035
Branches 1458 1458
===========================================
+ Hits 7486 7492 +6
+ Misses 1145 1143 -2
+ Partials 404 400 -4
|
alai97
changed the title
alai97
approved these changes
May 26, 2022
alai97
left a comment
alai97
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Will there be a doc update to iOS Advanced Configuration? We can port over these changes to that page too.
0xnm
reviewed
May 27, 2022
|
|
||
| for (String key : headers.names()) { | ||
| String attrName = "headers." + key.toLowerCase(Locale.US); | ||
| result.put(attrName, headers.values(key)); |
Member
There was a problem hiding this comment.
java snippet doesn't exactly match kotlin snippet: in Java we add all the values for the header name, in kotlin we add only a single value.
0xnm
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provide a documentation with samples for the
RumResourceAttributesProvider.