RUMM-2177: Use TLV format for data storage#931
Merged
Conversation
mariusc83
approved these changes
May 13, 2022
maxep
reviewed
May 13, 2022
maxep
left a comment
Member
There was a problem hiding this comment.
Nice work here!!
I think we could benefit from adding more flexibility on reading phase. We discussed that we should expect a pair of valid meta+event data but that would be when metadata is present. As we don't have yet needs for metadata, I dont think we should add it now. On iOS, we currently support stream with only events.
In short, when reading a block we would have these conditions:
- If we encounter an event, keep it
- If we encounter metadata, read next block and expect an event. Then we can decode both.
xgouchet
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change aligns the binary format used to write data to the disk with format implemented in DataDog/dd-sdk-ios#841.
For every event received we are going to write
meta+eventin the TLV (Type-Length-Value) format, where the format itself for each block (metaorevent) has the following structure:It is safe to merge it without cleaning existing data, because this PR targets SDK v2 branch, where the change later will be done to use SDK instance ID in the feature folder naming, so data in the SDK v2 read/write paths won't overlap with data from existing SDK (but during the current development existing data should be erased from emulator).
Tests are verified against the latest testable commit.
Review checklist (to be filled by reviewers)