Skip to content

Add github diff link on PR generated by the CI on new versions#927

Merged
daniel-m-dd merged 1 commit into
developfrom
ci_add_diff
May 8, 2022
Merged

Add github diff link on PR generated by the CI on new versions#927
daniel-m-dd merged 1 commit into
developfrom
ci_add_diff

Conversation

@daniel-m-dd

Copy link
Copy Markdown
Contributor

What does this PR do?

Add a link to the github tag diff page on PR opened by the CI on new version releases.

Motivation

Need a fast and easy way to. know the diff between two intermediate release (as the changelog reflects major release but not alpha/beta release)

Additional Notes

Not sure how to test it out of the release pipeline and on all repos using the script/CI PR generation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@daniel-m-dd
daniel-m-dd requested a review from a team as a code owner May 6, 2022 06:17
@codecov-commenter

codecov-commenter commented May 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #927 (a803769) into develop (efbe62a) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #927      +/-   ##
===========================================
- Coverage    83.08%   83.04%   -0.04%     
===========================================
  Files          267      267              
  Lines         9047     9049       +2     
  Branches      1453     1453              
===========================================
- Hits          7516     7514       -2     
- Misses        1137     1139       +2     
- Partials       394      396       +2     
Impacted Files Coverage Δ
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (-10.00%) ⬇️
...tadog/android/core/internal/net/CurlInterceptor.kt 80.95% <0.00%> (-2.38%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 94.48% <0.00%> (-0.61%) ⬇️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 95.83% <0.00%> (-0.03%) ⬇️
.../kotlin/com/datadog/android/ktx/rum/ClosableExt.kt 100.00% <0.00%> (ø)
...om/datadog/android/rum/webview/RumWebViewClient.kt 100.00% <0.00%> (ø)
.../android/webview/internal/rum/WebViewRumFeature.kt 100.00% <0.00%> (ø)
...tadog/android/fresco/DatadogFrescoCacheListener.kt 100.00% <0.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 92.06% <0.00%> (+0.26%) ⬆️
.../datadog/android/rum/webview/RumWebChromeClient.kt 81.48% <0.00%> (+1.48%) ⬆️

@daniel-m-dd
daniel-m-dd merged commit c6ca86f into develop May 8, 2022
@daniel-m-dd
daniel-m-dd deleted the ci_add_diff branch May 8, 2022 23:48
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants