DOCS-3301 add documentation to track background events#924
Merged
Conversation
0xnm
requested changes
May 4, 2022
|
|
||
| {{< tabs >}} | ||
| {{% tab "Java" %}} | ||
| ```swift |
Member
There was a problem hiding this comment.
Suggested change
| ```swift | |
| ```java |
Do we also need different tabs considering the call will look the same for both Kotlin and Java?
Contributor
There was a problem hiding this comment.
+1, if we are adding more tabs, please add this to the end after Line 340:
{{% /tab %}}
{{< /tabs >}}
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
==========================================
- Coverage 83.05% 83.01% -0.03%
==========================================
Files 267 267
Lines 9049 9049
Branches 1453 1453
==========================================
- Hits 7515 7512 -3
- Misses 1139 1140 +1
- Partials 395 397 +2
|
alai97
suggested changes
May 4, 2022
|
|
||
| {{< tabs >}} | ||
| {{% tab "Java" %}} | ||
| ```swift |
Contributor
There was a problem hiding this comment.
+1, if we are adding more tabs, please add this to the end after Line 340:
{{% /tab %}}
{{< /tabs >}}
alai97
changed the title
Co-authored-by: Nikita Ogorodnikov <[email protected]>
0xnm
approved these changes
May 27, 2022
xgouchet
approved these changes
May 27, 2022
alai97
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)