RUMM-2042: Fix E2E test#922
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #922 +/- ##
===========================================
- Coverage 82.86% 82.79% -0.07%
===========================================
Files 263 263
Lines 8977 8977
Branches 1449 1449
===========================================
- Hits 7438 7432 -6
- Misses 1144 1146 +2
- Partials 395 399 +4
|
xgouchet
approved these changes
May 3, 2022
xgouchet
reviewed
May 3, 2022
Comment on lines
+28
to
+33
| 2 -> v(message, throwable, attributes) | ||
| 3 -> d(message, throwable, attributes) | ||
| 4 -> i(message, throwable, attributes) | ||
| 5 -> w(message, throwable, attributes) | ||
| 6 -> e(message, throwable, attributes) | ||
| 7 -> wtf(message, throwable, attributes) |
Contributor
There was a problem hiding this comment.
Maybe we should reference the Log values
import android.util.Log
…
Suggested change
| 2 -> v(message, throwable, attributes) | |
| 3 -> d(message, throwable, attributes) | |
| 4 -> i(message, throwable, attributes) | |
| 5 -> w(message, throwable, attributes) | |
| 6 -> e(message, throwable, attributes) | |
| 7 -> wtf(message, throwable, attributes) | |
| Log.VERBOSE -> v(message, throwable, attributes) | |
| Log.DEBUG -> d(message, throwable, attributes) | |
| Log.INFO -> i(message, throwable, attributes) | |
| Log.WARN -> w(message, throwable, attributes) | |
| Log.ERROR -> e(message, throwable, attributes) | |
| Log.ASSERT -> wtf(message, throwable, attributes) |
Member
Author
There was a problem hiding this comment.
Indeed, it improves the readability. Thanks for the suggestion.
0xnm
force-pushed
the
nogorodnikov/rumm-2042/fix-e2e-test
branch
from
May 3, 2022 12:26
179262f to
33e566a
Compare
mariusc83
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up for #920. Apparently numbers used in branches of
sendRandomLogwere not the same as actual values ofLogpriorities.Review checklist (to be filled by reviewers)