RUMM-2042: Filter Datadog logs per level#920
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #920 +/- ##
===========================================
- Coverage 83.02% 82.81% -0.21%
===========================================
Files 267 263 -4
Lines 9057 8977 -80
Branches 1456 1449 -7
===========================================
- Hits 7519 7434 -85
- Misses 1139 1147 +8
+ Partials 399 396 -3
|
xgouchet
reviewed
May 2, 2022
| class DatadogTree( | ||
| private val logger: Logger | ||
| private val logger: Logger, | ||
| private val minLogPriority: Int = -1 |
Contributor
There was a problem hiding this comment.
Is this one really necessary? After all people can set the min priority when building the logger passed in parameter.
Member
Author
There was a problem hiding this comment.
Updated my PR, replaced it by a secondary constructor which will create a default logger with min priority set.
mariusc83
approved these changes
May 2, 2022
…eate a default DD logger with min level set
0xnm
force-pushed
the
nogorodnikov/rumm-2042/filter-logs-per-level
branch
from
May 2, 2022 09:09
4f8048d to
2ff8024
Compare
xgouchet
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #847. This PR includes the following:
loggerwith min priority log level set in theDatadogTree(Timber integration module).Logger.Builderconfiguration (main SDK module). Note:logcatlogs are not affected by this parameter.Motivation
This feature is useful when Datadog logger is used in the collaboration with other loggers and there is need for more granular control for Datadog logger to avoid sending unwanted log levels to avoid exploding log volume usage (can be the case of verbose or debug logs).
Review checklist (to be filled by reviewers)