Skip to content

RUMM-2084: Delete API v1 related classes#915

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2084/delete-api-v1-related-classes
Apr 29, 2022
Merged

RUMM-2084: Delete API v1 related classes#915
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2084/delete-api-v1-related-classes

Conversation

@0xnm

@0xnm 0xnm commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Since we are using API v2 for a while already and it is deployed in all DCs, let's remove API v1 classes, they are not used anyway.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner April 28, 2022 07:46
@codecov-commenter

codecov-commenter commented Apr 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.81%. Comparing base (54498c8) to head (69f6fc2).
⚠️ Report is 3717 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #915      +/-   ##
===========================================
- Coverage    82.89%   82.81%   -0.07%     
===========================================
  Files          267      263       -4     
  Lines         9057     8967      -90     
  Branches      1456     1448       -8     
===========================================
- Hits          7507     7426      -81     
+ Misses        1147     1141       -6     
+ Partials       403      400       -3
Files with missing lines Coverage Δ
.../android/core/internal/net/DataOkHttpUploaderV2.kt 98.77% <100.00%> (ø)
...og/android/rum/internal/net/RumOkHttpUploaderV2.kt 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet xgouchet added the size-medium This PR is medium sized label Apr 28, 2022
@0xnm
0xnm merged commit 553c26b into develop Apr 29, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2084/delete-api-v1-related-classes branch April 29, 2022 12:55
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83