RUMM-2150: Fix race condition in the features folders creation logic#912
Merged
0xnm merged 1 commit intoApr 27, 2022
Conversation
mariusc83
approved these changes
Apr 26, 2022
xgouchet
approved these changes
Apr 27, 2022
0xnm
deleted the
nogorodnikov/rumm-2150/fix-race-condition-in-feature-folders-creation
branch
April 27, 2022 09:49
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a race condition in the features folders creation logic. It may occur when one thread checks for the existence of the root dit for the feature, gets that folder doesn't exist and goes in the folder creation logic branch, and another thread does the same. This may lead to a situation when both threads will call
File#mkdirsbut only one of them will get a successful result, because another one will get a failure since folder is already created.Not sure if this situation can happen often in the client setup, but it happens in our nightly test runs when we do a call to change a consent (so to migrate files from one dir to another) right after SDK initialization step, which impacts test outcome.
Review checklist (to be filled by reviewers)