Ignore IO exceptions in Kronos for telemetry reporting#910
Merged
0xnm merged 1 commit intoApr 27, 2022
Merged
Conversation
mariusc83
approved these changes
Apr 25, 2022
Codecov Report
@@ Coverage Diff @@
## develop #910 +/- ##
===========================================
+ Coverage 83.04% 83.06% +0.01%
===========================================
Files 267 267
Lines 9047 9047
Branches 1453 1453
===========================================
+ Hits 7513 7514 +1
+ Misses 1139 1137 -2
- Partials 395 396 +1
|
xgouchet
approved these changes
Apr 27, 2022
0xnm
deleted the
nogorodnikov/ignore-ioexceptions-in-kronos-for-telemetry
branch
April 27, 2022 09:42
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change widens the scope of the exceptions thrown by Kronos library to be reported with telemetry. Apparently it can throw InvalidServerReplyException when server is not a valid state (like
leapvalue is equal to0b11, meaning server is not synchronized, check NTP RFC).We cannot address such issues anyway and if NTP servers are not healthy it will be caught by infra monitoring.
To avoid spammy telemetry entries this PR adds all
IOExceptioninstances to the ignore list.Review checklist (to be filled by reviewers)