DOCS-3292 Android Mobile Vitals Edits#892
Merged
Merged
Conversation
charlesbaiden
left a comment
charlesbaiden
left a comment
There was a problem hiding this comment.
hey Austin, LGTM - Just to confirm, we're going to have the same for iOS and ReactNative, right? Also I think we should wait for a couple of weeks before we push this to prod so that we can get the picture of the new Mobile Vitals widget, what do you think? Otherwise, thanks for updating the docs! :)
maycmlee
approved these changes
Apr 4, 2022
maycmlee
left a comment
maycmlee
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of small edits!
Co-authored-by: May Lee <[email protected]>
xgouchet
approved these changes
Apr 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
==========================================
- Coverage 81.65% 81.39% -0.26%
==========================================
Files 255 255
Lines 8533 8538 +5
Branches 1450 1452 +2
==========================================
- Hits 6967 6949 -18
- Misses 1232 1251 +19
- Partials 334 338 +4
|
mariusc83
approved these changes
Apr 5, 2022
alai97
commented
Apr 7, 2022
alai97
left a comment
alai97
left a comment
Contributor
Author
There was a problem hiding this comment.
Event Timings appears in the side panel with metrics only, graphs appear in Mobile Vitals on the Overview page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small doc edit for Android Mobile Vitals.
Motivation
DOCS-3292
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)