Handle missed orphans#871
Merged
Merged
Conversation
0xnm
reviewed
Mar 16, 2022
| onViewDisplayed(event, viewScope, actualWriter) | ||
| activeChildrenScopes.add(viewScope) | ||
| } else if (activeChildrenScopes.size == 0) { | ||
| } else if (activeChildrenScopes.count { it.isActive() } == 0) { |
Member
There was a problem hiding this comment.
Should we rename activeChildrenScopes field somehow? Or use other naming for isActive? Because with that change it introduces some ambiguity: basically this line says that activeChildrenScopes can contain some scope which is not actually active (and activeChildrenScopes was filtered just few lines above).
Or we can introduce set of states for RumScope: active, stopping, stopped or something like this. WDYT?
Contributor
Author
There was a problem hiding this comment.
Indeed I'll rename activeChildrenScopes -> childrenScopes
0xnm
approved these changes
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## release/1.12.0 #871 +/- ##
==================================================
- Coverage 80.44% 80.19% -0.25%
==================================================
Files 254 254
Lines 8533 8547 +14
Branches 1458 1463 +5
==================================================
- Hits 6864 6854 -10
- Misses 1323 1342 +19
- Partials 346 351 +5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #849
Some orphan events were not counted as orphans