Skip to content

RUMM-1837: Add org.json support for the event attributes#792

Merged
0xnm merged 2 commits into
masterfrom
nogorodnikov/rumm-1837/support-adding-org-json-to-loggers
Dec 22, 2021
Merged

RUMM-1837: Add org.json support for the event attributes#792
0xnm merged 2 commits into
masterfrom
nogorodnikov/rumm-1837/support-adding-org-json-to-loggers

Conversation

@0xnm

@0xnm 0xnm commented Dec 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Closes #588. This change adds support of org.json.JSONArray and org.json.JSONObject classes (which come with Android SDK) in the Logger#addAttribute call.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 21, 2021 15:05
@xgouchet xgouchet added the size-medium This PR is medium sized label Dec 21, 2021
@codecov-commenter

codecov-commenter commented Dec 21, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #792 (b501c61) into master (1cce72d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #792      +/-   ##
============================================
+ Coverage     88.30%   88.40%   +0.10%     
- Complexity     1822     1825       +3     
============================================
  Files           196      196              
  Lines          6402     6413      +11     
  Branches        741      746       +5     
============================================
+ Hits           5653     5669      +16     
  Misses          504      504              
+ Partials        245      240       -5
Impacted Files Coverage Δ
...m/datadog/android/core/internal/utils/MiscUtils.kt 50.00% <100.00%> (+8.62%) ⬆️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 97.83% <100.00%> (+0.02%) ⬆️
...id/log/internal/domain/event/LogEventSerializer.kt 94.74% <0.00%> (-5.26%) ⬇️
...nal/tracking/AndroidXFragmentLifecycleCallbacks.kt 91.11% <0.00%> (-4.44%) ⬇️
...nternal/tracking/OreoFragmentLifecycleCallbacks.kt 92.16% <0.00%> (-3.92%) ⬇️
...g/android/rum/internal/domain/scope/RumEventExt.kt 85.22% <0.00%> (-0.87%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.79% <0.00%> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 79.38% <0.00%> (ø)
...com/datadog/android/compose/InteractionTracking.kt 81.51% <0.00%> (+0.68%) ⬆️
... and 5 more

@fuzzybinary fuzzybinary mentioned this pull request Dec 21, 2021
Merged
@0xnm
0xnm merged commit 3f72e97 into master Dec 22, 2021
@0xnm
0xnm deleted the nogorodnikov/rumm-1837/support-adding-org-json-to-loggers branch December 22, 2021 12:40
@xgouchet xgouchet added this to the 1.12.0 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Allow org.json.JSONObject attributes

3 participants

@0xnm @codecov-commenter @xgouchet