RUMM-1762 Read is_crash info from cross platform attributes#764
Merged
Conversation
mariusc83
approved these changes
Nov 18, 2021
| source = event.source.toSchemaSource(), | ||
| stack = event.stacktrace ?: event.throwable?.loggableStackTrace(), | ||
| isCrash = event.isFatal, | ||
| isCrash = event.isFatal || (isFatal), |
Member
There was a problem hiding this comment.
why do you use brackets here ?
0xnm
approved these changes
Nov 19, 2021
xgouchet
force-pushed
the
xgouchet/RUMM-1762/read_crash_from_cp
branch
from
November 19, 2021 15:17
b404430 to
09bc8be
Compare
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
============================================
- Coverage 89.06% 88.75% -0.31%
- Complexity 1782 1783 +1
============================================
Files 194 194
Lines 6116 6118 +2
Branches 703 705 +2
============================================
- Hits 5447 5430 -17
- Misses 441 453 +12
- Partials 228 235 +7
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Read
error.is_crashinfo from cross platform attributes