Skip to content

RUMM-1721 Prevent crashes in WindowCallbackWrapper#732

Merged
xgouchet merged 3 commits into
release/1.11.0from
xgouchet/RUMM-1721/WindowCallbackWrapper
Oct 27, 2021
Merged

RUMM-1721 Prevent crashes in WindowCallbackWrapper#732
xgouchet merged 3 commits into
release/1.11.0from
xgouchet/RUMM-1721/WindowCallbackWrapper

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Prevent crashes in WindowCallbackWrapper when delegating events to wrapped callback.

@xgouchet
xgouchet requested a review from a team as a code owner October 22, 2021 08:56
@xgouchet
xgouchet changed the base branch from master to release/1.11.0 October 22, 2021 08:56
@xgouchet xgouchet added the size-medium This PR is medium sized label Oct 22, 2021
@xgouchet
xgouchet force-pushed the xgouchet/RUMM-1721/WindowCallbackWrapper branch from a265c0e to 91703f4 Compare October 27, 2021 08:28
@0xnm

0xnm commented Oct 27, 2021

Copy link
Copy Markdown
Member

This PR needs to be rebased onto fresh master, failing tests issue was fixed in this commit d04dba3.

@xgouchet

Copy link
Copy Markdown
Contributor Author

Thanks for the tip @0xnm , I'll cherry pick this as I want to merge it on the beta branch

@xgouchet
xgouchet merged commit ac4f0d9 into release/1.11.0 Oct 27, 2021
@xgouchet
xgouchet deleted the xgouchet/RUMM-1721/WindowCallbackWrapper branch October 27, 2021 10:38
@xgouchet xgouchet added this to the 1.11.0 milestone Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-medium This PR is medium sized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants