Skip to content

RUMM-1349 Data upload Proxy#687

Merged
xgouchet merged 2 commits into
masterfrom
xgouchet/RUMM-1349/proxy
Aug 25, 2021
Merged

RUMM-1349 Data upload Proxy#687
xgouchet merged 2 commits into
masterfrom
xgouchet/RUMM-1349/proxy

Conversation

@xgouchet

@xgouchet xgouchet commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Enable proxy configuration for tracked data upload to Datadog intake.

Motivation

Fixes #592

@xgouchet
xgouchet requested a review from a team as a code owner August 25, 2021 08:33
@codecov-commenter

codecov-commenter commented Aug 25, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #687 (df6a014) into master (810db97) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #687      +/-   ##
============================================
+ Coverage     88.48%   88.79%   +0.31%     
- Complexity     1692     1696       +4     
============================================
  Files           189      189              
  Lines          5598     5609      +11     
  Branches        683      685       +2     
============================================
+ Hits           4953     4980      +27     
+ Misses          407      394      -13     
+ Partials        238      235       -3
Impacted Files Coverage Δ
...atadog/android/core/configuration/Configuration.kt 96.27% <100.00%> (+0.50%) ⬆️
...n/com/datadog/android/core/internal/CoreFeature.kt 98.32% <100.00%> (+0.03%) ⬆️
...sistence/file/advanced/ConsentAwareFileMigrator.kt 88.24% <0.00%> (-2.94%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 86.79% <0.00%> (-1.89%) ⬇️
...g/android/rum/internal/domain/scope/RumEventExt.kt 80.91% <0.00%> (-1.82%) ⬇️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 97.46% <0.00%> (-0.85%) ⬇️
...roid/rum/internal/domain/scope/RumResourceScope.kt 93.46% <0.00%> (ø)
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 95.92% <0.00%> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 78.12% <0.00%> (ø)
... and 6 more

@xgouchet xgouchet added the size-small This PR is small sized label Aug 25, 2021
ncreated
ncreated approved these changes Aug 25, 2021
View reviewed changes

@ncreated ncreated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Very clean

@xgouchet
xgouchet merged commit be12587 into master Aug 25, 2021
@xgouchet
xgouchet deleted the xgouchet/RUMM-1349/proxy branch August 25, 2021 12:00
@xgouchet xgouchet added this to the 1.11.0 milestone Aug 25, 2021
@ruXlab

ruXlab commented Sep 3, 2021

Copy link
Copy Markdown

Thanks for the fix! Do you have any eta when is it going to be published? Do you have a snapshot artefacts URL?
Thanks

@xgouchet

xgouchet commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

Hi @ruXlab, we'll probably start publishing a beta version in a couple of weeks, but no exact ETA yet

@0xnm 0xnm mentioned this pull request Sep 14, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

No one assigned

Labels

size-small This PR is small sized

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

Option to provide an HTTP proxy or custom OkHttpBuilder / factory

4 participants

@xgouchet @codecov-commenter @ruXlab @ncreated