Conversation
…penTracing format
xgouchet
approved these changes
Mar 16, 2021
mariusc83
approved these changes
Mar 16, 2021
| if (errorType != null) { | ||
| val stackField = map.remove(Fields.STACK) | ||
| val msgField = map.remove(Fields.MESSAGE) | ||
| val msgField = map[Fields.MESSAGE] |
Member
There was a problem hiding this comment.
I think the reason it was like that is that I followed what they are doing in the APM project.
0xnm
deleted the
nogorodnikov/rumm-1180/keep-message-for-logs-when-it-comes-with-error-fields-in-opentracing
branch
March 17, 2021 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #522 . Before this change
MESSAGEfield was removed from the collection if it also contains error fields as part ofextractErrormethod, and then for the logs default message was used (since original was removed). But it actually makes sense to propagate it to the logs as well.Review checklist (to be filled by reviewers)