Fix R8 failures due to missing SourceLines annotation in 3.12.0#3641
Closed
abrooksv wants to merge 32 commits into
Closed
Fix R8 failures due to missing SourceLines annotation in 3.12.0#3641abrooksv wants to merge 32 commits into
abrooksv wants to merge 32 commits into
Conversation
This is the first step to migrating off the shared static analysis pipeline * Consolidate Detekt configurations together * Use Detekt Gradle plugin to execute Detekt
Next dev iteration
Merge release/3.12.0 into develop Co-authored-by: ambushwork <[email protected]>
RUM-17238: Use Gradle plugin to run detekt
…ations" This reverts commit d361e7e.
In CI, we monitor tests and our build via dd-trace-java. The issue is that for java compile tasks, they inject a javac plugin that adds in a SourceLines and SourcePath annotation. The issue is that this injected annotation is not in our runtime dependencies, so R8 will fail due to the missing annotation
abrooksv
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3641 +/- ##
===========================================
- Coverage 73.32% 73.25% -0.06%
===========================================
Files 995 995
Lines 36273 36282 +9
Branches 6126 6126
===========================================
- Hits 26594 26578 -16
- Misses 7977 8004 +27
+ Partials 1702 1700 -2 🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
Jul 15, 2026
abrooksv
marked this pull request as ready for review
July 15, 2026 18:50
ambushwork
previously approved these changes
Jul 15, 2026
abrooksv
dismissed stale reviews from ambushwork and 0xnm
July 15, 2026 20:02
The base branch was changed.
abrooksv
requested review from
pavlokhrebto and
typotter
and removed request for
a team
July 15, 2026 20:02
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In CI, we monitor tests and our build via dd-trace-java. The issue is that for java compile tasks, they inject a javac plugin that adds in a SourceLines and SourcePath annotation. The issue is that this injected annotation is not in our runtime dependencies, so R8 will fail due to the missing annotation
Ramification for us is that our tests in the Test Optimization product may have their line numbers not as accurate due to the standard method line number table only tracks executable lines, so it won't include comments or method declaration in the UI.
Verification
Ran locally with
org.gradle.jvmargs=-Xmx4096m -javaagent:/tmp/dd-tracer-repro/dd-java-agent.jar=dd.env=ci,dd.trace.enabled=false,dd.jmx.fetch.enabled=false,dd.trace.debug=true,dd.trace.startup.logs=trueWith proposed fix locally:
org.gradle.jvmargs=-Xmx4096m -javaagent:/tmp/dd-tracer-repro/dd-java-agent.jar=dd.env=ci,dd.trace.enabled=false,dd.jmx.fetch.enabled=false,dd.civisibility.compiler.plugin.auto.configuration.enabled=falseMotivation
Fixes #3639
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)