RUM-17112: Remove default = Time() from RumRawEvent subclasses#3608
Merged
Conversation
kikoveiga
force-pushed
the
kikoveiga/rum-17112/remove-default-time
branch
from
July 5, 2026 17:38
dd56a76 to
501ba86
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3608 +/- ##
===========================================
- Coverage 72.89% 72.88% -0.01%
===========================================
Files 975 975
Lines 35277 35298 +21
Branches 5972 5974 +2
===========================================
+ Hits 25712 25724 +12
- Misses 7905 7915 +10
+ Partials 1660 1659 -1
🚀 New features to boost your workflow:
|
kikoveiga
force-pushed
the
kikoveiga/rum-17112/remove-default-time
branch
6 times, most recently
from
July 8, 2026 15:22
2803b08 to
bf0f783
Compare
kikoveiga
marked this pull request as ready for review
July 8, 2026 15:27
abrooksv
previously approved these changes
Jul 8, 2026
kikoveiga
force-pushed
the
kikoveiga/rum-17112/remove-default-time
branch
from
July 8, 2026 16:23
bf0f783 to
8f747cf
Compare
abrooksv
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
= Time()default from allRumRawEventsubclasses and makeseventTimean explicit constructor argument, sourced through the injectedTimeProvider.Time.now(timeProvider);Time.fromTimestampMillis(timestamp, timeProvider)andTime.fromNanoTime(nanoTime, timeProvider)replace the old extensions.TimeForgeryFactoryand reuses it in tests.Motivation
The no-arg
Time()calledSystem.currentTimeMillis()andSystem.nanoTime()apis directly, bypassingTimeProvider. This finished the goal of #3011 and makes RUM event timing fully deterministic and testable.Review checklist (to be filled by reviewers)