RUM-14050: Disable auto-cancel on develop and feature branches#3602
Conversation
abrooksv
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a7f2a36ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on_new_commit: interruptible # short-lived branches cancel on new commits | ||
| - when: always # develop, master, feature/*, tags: never auto-canceled | ||
| auto_cancel: | ||
| on_new_commit: none |
There was a problem hiding this comment.
For merge request pipelines from non-develop/master/non-feature/* branches, GitLab does not set CI_COMMIT_BRANCH, so the first rule is skipped and this unconditional fallback now forces on_new_commit: none. That means the MR pipeline for a short-lived branch such as bugfix/foo will no longer be canceled on subsequent pushes even though the matching branch pipeline still uses interruptible; use CI_MERGE_REQUEST_SOURCE_BRANCH_NAME or exclude MR pipelines from this fallback to keep the intended short-lived behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Not relevant, we don't create MRs in GitLab, only use the CI system so only CI_COMMIT_BRANCH will be set
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3602 +/- ##
===========================================
- Coverage 72.85% 72.83% -0.03%
===========================================
Files 975 975
Lines 35277 35270 -7
Branches 5972 5974 +2
===========================================
- Hits 25700 25686 -14
- Misses 7915 7918 +3
- Partials 1662 1666 +4 🚀 New features to boost your workflow:
|
3 participants
What does this PR do?
Follow up to #3584
Change the fallback for auto-cancel to be
noneinstead of the project settingMotivation
I did not enough enough permissions in Gitlab to see that the project has auto-cancel turned on at the project level. CI Infra confirmed it is on. This means that when jobs were marked as interruptible, we started cancelling them on the develop and feature branches which was not the intention of #3584. This PR overrides the project setting to be
nonewhich restores our old behavior