RUM-17079: Sign the CI image#3593
Merged
Merged
Conversation
ambushwork
previously approved these changes
Jul 1, 2026
hamorillo
reviewed
Jul 1, 2026
| script: | ||
| - docker buildx build --tag $CI_IMAGE_DOCKER -f ./ci/Dockerfile.gitlab --push . | ||
| - METADATA_FILE=$(mktemp) | ||
| - docker buildx build --tag $CI_IMAGE_DOCKER -f ./ci/Dockerfile.gitlab --push ---metadata-file ${METADATA_FILE} . |
Contributor
There was a problem hiding this comment.
-:
Suggested change
| - docker buildx build --tag $CI_IMAGE_DOCKER -f ./ci/Dockerfile.gitlab --push ---metadata-file ${METADATA_FILE} . | |
| - docker buildx build --tag $CI_IMAGE_DOCKER -f ./ci/Dockerfile.gitlab --push --metadata-file ${METADATA_FILE} . |
Contributor
There was a problem hiding this comment.
Yes. Also, I think these 3 commands should be in a single - | block chained with &&.
@abrooksv please trigger the ci-image GitLab manual step as well after these changes.
Contributor
Author
There was a problem hiding this comment.
Any particular reason for the &&? They fail fast in a list and easier to read in the logs since they are separated IMO
satween
previously approved these changes
Jul 1, 2026
Co-authored-by: Héctor Abraham Morillo Prieto <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3593 +/- ##
===========================================
- Coverage 72.81% 72.74% -0.07%
===========================================
Files 974 974
Lines 35226 35226
Branches 5968 5968
===========================================
- Hits 25649 25625 -24
- Misses 7918 7929 +11
- Partials 1659 1672 +13 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sign the docker image we use in CI