Skip to content

RUM-14050: Cancel stale PR pipeline runs in Gitlab#3584

Merged
abrooksv merged 1 commit into
developfrom
abrooks/kill-stale-pipeline-runs
Jun 29, 2026
Merged

RUM-14050: Cancel stale PR pipeline runs in Gitlab#3584
abrooksv merged 1 commit into
developfrom
abrooks/kill-stale-pipeline-runs

Conversation

@abrooksv

@abrooksv abrooksv commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Since we have a limited size of Mac runners, kill off pipeline jobs for PRs if a newer commit is pushed

Docs: https://support.gitlab.com/hc/en-us/articles/22118112967068-How-to-auto-cancel-redundant-pipelines

Motivation

Try to reduce the amount of time waiting on our test-pyramid jobs due to stale runs

@abrooksv
abrooksv force-pushed the abrooks/kill-stale-pipeline-runs branch from 565dd1b to 51e79f1 Compare June 26, 2026 23:15
@abrooksv
abrooksv marked this pull request as ready for review June 26, 2026 23:17
@abrooksv
abrooksv requested review from a team as code owners June 26, 2026 23:17
@abrooksv
abrooksv force-pushed the abrooks/kill-stale-pipeline-runs branch from 51e79f1 to 1e577e9 Compare June 26, 2026 23:23
@codecov-commenter

codecov-commenter commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.78%. Comparing base (9e60d05) to head (0a000f0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3584      +/-   ##
===========================================
- Coverage    72.80%   72.78%   -0.02%     
===========================================
  Files          974      974              
  Lines        35228    35230       +2     
  Branches      5965     5968       +3     
===========================================
- Hits         25645    25639       -6     
- Misses        7915     7919       +4     
- Partials      1668     1672       +4     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kikoveiga
kikoveiga previously approved these changes Jun 27, 2026

@kikoveiga kikoveiga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add interruptible: false to the manual jobs ci-image and create_key? Just to make sure they don't get interrupted and their outputs get corrupted, even though this is very unlikely to happen.

@abrooksv

Copy link
Copy Markdown
Contributor Author

Should we also add interruptible: false to the manual jobs ci-image and create_key? Just to make sure they don't get interrupted and their outputs get corrupted, even though this is very unlikely to happen.

Good call

jonathanmos
jonathanmos previously approved these changes Jun 28, 2026
ambushwork
ambushwork previously approved these changes Jun 29, 2026
hamorillo
hamorillo previously approved these changes Jun 29, 2026

@hamorillo hamorillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Since we have a limited size of Mac runners, kill off pipeline jobs for PRs if a newer commit is pushed
@abrooksv
abrooksv force-pushed the abrooks/kill-stale-pipeline-runs branch from 1e577e9 to 0a000f0 Compare June 29, 2026 15:02
@abrooksv
abrooksv requested a review from kikoveiga June 29, 2026 15:02
@abrooksv
abrooksv merged commit 655a93a into develop Jun 29, 2026
27 checks passed
@abrooksv
abrooksv deleted the abrooks/kill-stale-pipeline-runs branch June 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants