Fix issue with RumViewScope caused by merge#3574
Merged
Merged
Conversation
aleksandr-gringauz
approved these changes
Jun 25, 2026
jonathanmos
marked this pull request as ready for review
June 25, 2026 08:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3574 +/- ##
===========================================
+ Coverage 72.47% 72.58% +0.11%
===========================================
Files 978 978
Lines 36069 36045 -24
Branches 6041 6040 -1
===========================================
+ Hits 26138 26162 +24
+ Misses 8246 8210 -36
+ Partials 1685 1673 -12
🚀 New features to boost your workflow:
|
hamorillo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This merge seems to have caused a duplicated code block in RumViewScope. This wasn't caught by tests in develop but was caught by a test on the dogfooding branch.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)