Split detekt safe calls into two files#3572
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3572 +/- ##
===========================================
- Coverage 72.53% 72.50% -0.03%
===========================================
Files 978 978
Lines 36058 36065 +7
Branches 6041 6039 -2
===========================================
- Hits 26152 26148 -4
- Misses 8234 8250 +16
+ Partials 1672 1667 -5 🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
June 24, 2026 12:58
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e33293377
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jonathanmos
force-pushed
the
jmoskovich/split-custom-detekt
branch
from
June 24, 2026 13:06
3e33293 to
f5ee77d
Compare
kikoveiga
previously approved these changes
Jun 24, 2026
hamorillo
reviewed
Jun 24, 2026
abrooksv
previously approved these changes
Jun 24, 2026
kikoveiga
previously approved these changes
Jun 24, 2026
hamorillo
previously approved these changes
Jun 24, 2026
jonathanmos
dismissed stale reviews from hamorillo, kikoveiga, and abrooksv
via
June 24, 2026 14:43
f3361f9
jonathanmos
force-pushed
the
jmoskovich/split-custom-detekt
branch
from
June 24, 2026 14:43
b68fa2b to
f3361f9
Compare
hamorillo
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
detekt_custom_safe_calls.yml had grown large enough to hit SnakeYAML's parsing limits, causing CI to fail. This PR splits it into two files to bring each under the limit:
detekt_custom_safe_calls_android.yml — Android platform APIs (android., androidx., Google Material)
detekt_custom_safe_calls_third_party.yml — Third-party and stdlib entries (OkHttp, Gson, Apollo, Cronet, Glide, Kotlin stdlib, Java stdlib, RxJava, etc.)
To support this, the UnsafeThirdPartyFunctionCall rule now reads two distinct config keys (knownSafeAndroidCalls and knownSafeThirdPartyCalls) instead of a single knownSafeCalls list. This mirrors the existing pattern used for knownThrowingCalls / knownSafeCalls across separate files, avoiding any YAML merge issues when passing multiple config files to detekt.
Two pre-existing bugs in DetektCustomConfig are also fixed as part of this change:
detekt_classpath was read at Gradle configuration time, causing "Could not create task" failures on clean checkouts; it is now read in doFirst
customDetektRules had no dependsOn("printDetektClasspath"), so detekt_classpath could be missing at execution time
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)