Skip to content

RUM-16696: Attach profiling context to the View events#3562

Merged
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/attach-profiling-context-to-view-events
Jun 23, 2026
Merged

RUM-16696: Attach profiling context to the View events#3562
ambushwork merged 1 commit into
feature/continuous-profilingfrom
yl/profiling/attach-profiling-context-to-view-events

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Attach profiling context to the View events as we did for RUM Errors and Vitals

Motivation

RUM-16696

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork marked this pull request as ready for review June 22, 2026 07:53
@ambushwork
ambushwork requested review from a team as code owners June 22, 2026 07:53
@codecov-commenter

codecov-commenter commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.48%. Comparing base (0ceaec7) to head (624840d).

Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/continuous-profiling    #3562      +/-   ##
================================================================
+ Coverage                         72.46%   72.48%   +0.01%     
================================================================
  Files                               987      987              
  Lines                             36595    36604       +9     
  Branches                           6094     6096       +2     
================================================================
+ Hits                              26518    26529      +11     
+ Misses                             8414     8413       -1     
+ Partials                           1663     1662       -1     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 95.05% <100.00%> (+0.34%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}

private fun resolveViewProfilingStatus(datadogContext: DatadogContext): ViewEvent.Profiling? {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to better understand.

What profiler run this status corresponds to? I mean there can be application launch profiling, continious profiling, 1 RUM session can have many of them (correct me if I am wrong here).

Is it the most recent one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProfilingStatus represents if there is a profiling session on going - more specifically speaking - if a profiling session which is manually requested by SDK through ProfilingManager.requestProfiling is running, it means app launch profiling and continuous profiling will update this status, (they don't overlap since ProfilingManager doesn't support multiple profile sessions through request), but it doesn't include the trigger based profiling for ANR, which is a background profiler can run in parallel with our profiling session.

@ambushwork
ambushwork merged commit f31d3fe into feature/continuous-profiling Jun 23, 2026
27 checks passed
@ambushwork
ambushwork deleted the yl/profiling/attach-profiling-context-to-view-events branch June 23, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants