Move FakeSameThreadExecutorService into core textFixtures#3536
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
3 tasks
ambushwork
force-pushed
the
yl/move-fake-same-thread-executor-service
branch
from
June 12, 2026 08:50
c5f2d3d to
d37baeb
Compare
ambushwork
marked this pull request as ready for review
June 12, 2026 09:39
kikoveiga
approved these changes
Jun 12, 2026
ambushwork
force-pushed
the
yl/move-fake-same-thread-executor-service
branch
from
June 12, 2026 12:07
d37baeb to
535c2ae
Compare
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3536 +/- ##
===========================================
+ Coverage 72.21% 72.25% +0.03%
===========================================
Files 966 966
Lines 35654 35652 -2
Branches 5951 5952 +1
===========================================
+ Hits 25747 25758 +11
- Misses 8275 8281 +6
+ Partials 1632 1613 -19 🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FakeSameThreadExecutorServicecan be reused across all the module to fake anExecutorServiceto run the task on the same thread, this PRs move the class to core/textFixtures for the purpose.Review checklist (to be filled by reviewers)