refactor(flags): rename flag names to flag keys#3527
Merged
leoromanovsky merged 1 commit intoJun 10, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3527 +/- ##
===========================================
+ Coverage 72.18% 72.25% +0.07%
===========================================
Files 965 965
Lines 35635 35633 -2
Branches 5947 5948 +1
===========================================
+ Hits 25721 25744 +23
+ Misses 8296 8273 -23
+ Partials 1618 1616 -2
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
leoromanovsky
marked this pull request as ready for review
June 10, 2026 20:32
🐑 PR Shepherd is maintaining this PRI watch your PR and automatically fix CI failures, rebase your branch, handle flaky tests, and push it to the merge queue when it's ready. More about what I do → Guide To pause me on this PR, add the |
kikoveiga
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Feature flag identifiers are keys, not display names. The Android flags implementation already exposes
flagKeyin the publicFlagsClientAPI, but some internal processor, mapper, and test code still usedflagNameterminology.Changes
flagName/flagNamesidentifiers indd-sdk-android-flagsinternals toflagKey/flagKeys.Decisions
flagKey.features/dd-sdk-android-flags; RUM feature flag evaluation APIs and tests still use their existingname/flagNamevocabulary and are left untouched in this PR.