RUM-15577: Write CUSTOM RUM actions immediately#3525
Merged
aleksandr-gringauz merged 3 commits intoJun 11, 2026
Conversation
Contributor
Author
|
@codex review |
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3525 +/- ##
===========================================
+ Coverage 72.18% 72.22% +0.04%
===========================================
Files 965 965
Lines 35635 35635
Branches 5947 5947
===========================================
+ Hits 25721 25735 +14
+ Misses 8296 8283 -13
+ Partials 1618 1617 -1
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Jun 10, 2026
0xnm
approved these changes
Jun 11, 2026
hamorillo
approved these changes
Jun 11, 2026
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-15577/custom-action-fix
branch
June 11, 2026 08:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Custom RUM actions (
addAction(CUSTOM, ...)) are now written immediately instead of waiting on an inactivity timeout. Previously, a custom action with no subsequent event was never flushed and got lost.Motivation
Fixes RUM-15577. This also aligns Android with iOS, where discrete custom actions are sent instantly (regardless of whether another action is ongoing):
RUMViewScoperoutes.customactions to an instant sendsendDiscreteCustomUserActionflushes it immediatelyAdditional Notes
Behavior change: a standalone custom action no longer aggregates resources/errors over the 100ms window; it becomes a discrete immediate event (matching iOS). Non-custom discrete actions (tap/scroll) are unchanged.
Review checklist (to be filled by reviewers)