Skip to content

RUM-16653: Route androidNetworkInstrumentation through InternalLogger#logApiUsage#3516

Merged
abrooksv merged 1 commit into
developfrom
abrooks/decrease-network-usage-telemetry
Jun 8, 2026
Merged

RUM-16653: Route androidNetworkInstrumentation through InternalLogger#logApiUsage#3516
abrooksv merged 1 commit into
developfrom
abrooks/decrease-network-usage-telemetry

Conversation

@abrooksv

@abrooksv abrooksv commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The androidNetworkInstrumentation reporting was bypassing the logApiUsage API so it was being reporting at 100% event-level sampling. By moving it to go through the standard API, we will apply the standard 15% event sampling to decrease the number of events generated (decreasing effective_sampling_rate from 20% to 3%)

Motivation

Cost savings, see attached ticket for details

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

This comment has been minimized.

…#logApiUsage

The androidNetworkInstrumentation reporting was bypassing the logApiUsage API so it was being reporting at 100% event-level sampling. By moving it to go through the standard API, we will apply the standard 15% sampling to decrease the number of events generated
@abrooksv
abrooksv force-pushed the abrooks/decrease-network-usage-telemetry branch from 9d8e090 to 80f7acb Compare June 5, 2026 16:46
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.17%. Comparing base (7720f9c) to head (80f7acb).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3516      +/-   ##
===========================================
- Coverage    72.19%   72.17%   -0.03%     
===========================================
  Files          965      965              
  Lines        35602    35601       -1     
  Branches      5932     5932              
===========================================
- Hits         25702    25692      -10     
- Misses        8286     8292       +6     
- Partials      1614     1617       +3     
Files with missing lines Coverage Δ
.../android/rum/internal/monitor/DatadogRumMonitor.kt 86.03% <100.00%> (-1.01%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abrooksv
abrooksv marked this pull request as ready for review June 5, 2026 18:03
@abrooksv
abrooksv requested review from a team as code owners June 5, 2026 18:03
@kikoveiga
kikoveiga requested a review from satween June 6, 2026 16:25
@abrooksv
abrooksv merged commit 0b3c64a into develop Jun 8, 2026
27 checks passed
@abrooksv
abrooksv deleted the abrooks/decrease-network-usage-telemetry branch June 8, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants