RUM-16593: Fix WorkDatabase initialization crash in R8 full mode#3502
Merged
0xnm merged 1 commit intoJun 3, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3502 +/- ##
========================================
Coverage 72.23% 72.23%
========================================
Files 965 965
Lines 35595 35595
Branches 5932 5932
========================================
Hits 25712 25712
- Misses 8274 8275 +1
+ Partials 1609 1608 -1 🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Jun 3, 2026
0xnm
deleted the
nogorodnikov/rum-16593/fix-workdatabase-r8-fullmode-crash
branch
June 3, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See #3491 for the motivation.
Fix R8 fullMode crash when using WorkManager 2.8.1
R8 fullMode (enabled by default in AGP 9.x) strips the no-arg constructor of
WorkDatabase_Implbecause it's only called via reflection. WorkManager's own bundled ProGuard rules don't protect it. This adds a consumer ProGuard rule todd-sdk-android-coreso the constructor is preserved in any app consuming the SDK. We cannot update WorkManager dependency, because it will bring coroutines and also may impose compile SDK restrictions.Fixes #3491.
Review checklist (to be filled by reviewers)