RUM-16125: Add name support for the work units in BackPressureExecutorService#submit#3492
Merged
0xnm merged 1 commit intoJun 2, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
0xnm
force-pushed
the
nogorodnikov/add-name-to-the-backpressureexecutor-submit
branch
from
June 2, 2026 08:18
a9842bf to
08b828b
Compare
ambushwork
previously approved these changes
Jun 2, 2026
ambushwork
left a comment
ambushwork
left a comment
Member
There was a problem hiding this comment.
Optional: since now it's working, we can add tests in BackPressureExecutorServiceTest when submitting the task, the queue can be dumped with the name.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3492 +/- ##
===========================================
+ Coverage 72.18% 72.21% +0.02%
===========================================
Files 964 965 +1
Lines 35586 35595 +9
Branches 5928 5932 +4
===========================================
+ Hits 25687 25702 +15
- Misses 8278 8288 +10
+ Partials 1621 1605 -16
🚀 New features to boost your workflow:
|
Contributor
|
So does this fix RUM-16125? If so, please also remove the stale |
0xnm
force-pushed
the
nogorodnikov/add-name-to-the-backpressureexecutor-submit
branch
from
June 2, 2026 09:01
08b828b to
209f7f4
Compare
0xnm
changed the title
BackPressureExecutorService#submitBackPressureExecutorService#submit
ambushwork
approved these changes
Jun 2, 2026
kikoveiga
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuation of #3412.
Work units submitted using
ExecutorService.submitare getting wrapped into the future handles (this is what added to the queue), so this PR makes such future handles named as well.This will bring observability for the tasks submitted to the RUM executor.
dd-sdk-android/features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitor.kt
Line 883 in cafc384
Review checklist (to be filled by reviewers)