[Benchmark] Fix app crash when running baseline for SR scenario#3474
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
ambushwork
force-pushed
the
yl/benchmark/fix-session-replay-baseline
branch
from
May 26, 2026 16:27
f985a90 to
491333a
Compare
ambushwork
marked this pull request as ready for review
May 26, 2026 16:28
kikoveiga
approved these changes
May 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3474 +/- ##
===========================================
- Coverage 72.20% 72.17% -0.02%
===========================================
Files 964 964
Lines 35554 35554
Branches 5922 5922
===========================================
- Hits 25669 25661 -8
- Misses 8269 8276 +7
- Partials 1616 1617 +1 🚀 New features to boost your workflow:
|
0xnm
approved these changes
May 26, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous PR caused the crash on synthetics when running with Session Replay (Compose) scenario and baseline run:
This is because Session Replay (Compose) scenario has RUM enabled in baseline, but the SDK was not initialized.
Review checklist (to be filled by reviewers)