[Benchmarking] Enable RUM for Session Relay baseline run#3467
Merged
Conversation
kikoveiga
previously approved these changes
May 22, 2026
ambushwork
force-pushed
the
luyi/benchmark-sr-baseline-rum
branch
from
May 22, 2026 15:39
8d57c11 to
6e28600
Compare
ambushwork
force-pushed
the
luyi/benchmark-sr-baseline-rum
branch
from
May 22, 2026 15:42
6e28600 to
3c064c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3467 +/- ##
===========================================
- Coverage 72.21% 72.15% -0.06%
===========================================
Files 964 964
Lines 35554 35554
Branches 5922 5922
===========================================
- Hits 25673 25652 -21
- Misses 8263 8282 +19
- Partials 1618 1620 +2 🚀 New features to boost your workflow:
|
hamorillo
approved these changes
May 25, 2026
hamorillo
left a comment
hamorillo
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🚀
We just need to take into account that this will impact the number we are currently seeing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the benchmark app, SessionReplay and SessionReplayCompose scenarios now enable RUM in both baseline and instrumented runs (instead of only in instrumented), since Session Replay depends on RUM. This way the baseline-vs-instrumented delta isolates Session Replay's own overhead rather than conflating it with the cost of bringing up RUM.
Review checklist (to be filled by reviewers)