Skip to content

RUM-9307: Rename last_failure_status to retry_after#3459

Merged
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/RUM-9307/rename-to-retry-after
May 21, 2026
Merged

RUM-9307: Rename last_failure_status to retry_after#3459
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/RUM-9307/rename-to-retry-after

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented May 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Just renaming the tag.

Aligning with iOS and Browser.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.17%. Comparing base (057365c) to head (445273d).

Files with missing lines Patch % Lines
...adog/android/rum/internal/net/RumRequestFactory.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3459      +/-   ##
===========================================
- Coverage    72.31%   72.17%   -0.14%     
===========================================
  Files          964      964              
  Lines        35500    35500              
  Branches      5897     5897              
===========================================
- Hits         25670    25620      -50     
- Misses        8237     8257      +20     
- Partials      1593     1623      +30     
Files with missing lines Coverage Δ
...adog/android/rum/internal/net/RumRequestFactory.kt 56.94% <0.00%> (-6.94%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review May 21, 2026 08:14
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners May 21, 2026 08:14
@aleksandr-gringauz
aleksandr-gringauz merged commit afa0951 into develop May 21, 2026
28 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/RUM-9307/rename-to-retry-after branch May 21, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants