RUM-16087: Catch Throwable.loggableStackTrace() throws#3458
Merged
kikoveiga merged 1 commit intoMay 20, 2026
Conversation
kikoveiga
force-pushed
the
kikoveiga/rum-16087/catch-loggable-stacktrace-throws
branch
3 times, most recently
from
May 20, 2026 15:19
4fb0038 to
13d6aea
Compare
kikoveiga
changed the title
loggableStackTrace throwsThrowable#loggableStackTrace throws
kikoveiga
changed the title
Throwable#loggableStackTrace throwsThrowable.loggableStackTrace() throws
kikoveiga
marked this pull request as ready for review
May 20, 2026 15:40
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d6aea655
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kikoveiga
force-pushed
the
kikoveiga/rum-16087/catch-loggable-stacktrace-throws
branch
2 times, most recently
from
May 20, 2026 16:03
5293d29 to
a0e66fa
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
kikoveiga
force-pushed
the
kikoveiga/rum-16087/catch-loggable-stacktrace-throws
branch
from
May 20, 2026 16:09
a0e66fa to
2576337
Compare
aleksandr-gringauz
approved these changes
May 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3458 +/- ##
===========================================
- Coverage 72.31% 72.19% -0.12%
===========================================
Files 964 964
Lines 35500 35503 +3
Branches 5897 5898 +1
===========================================
- Hits 25670 25629 -41
- Misses 8237 8263 +26
- Partials 1593 1611 +18
🚀 New features to boost your workflow:
|
kikoveiga
deleted the
kikoveiga/rum-16087/catch-loggable-stacktrace-throws
branch
May 20, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Throwable.loggableStackTrace()in atry - catchblock.Motivation
Throwable.printStackTrace()can throw, as seen here, which would silently drop the entire crash report. According to my quick investigation, it might be due to older versions ofkotlinx.coroutinesthat had an internal bug in how they handle state.