RUM-15510: Resolve dependencies through Magic Mirror Depot in CI#3452
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 448cdf631a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Routes Gradle dependency and plugin resolution through Datadog's internal Magic Mirror Depot (depot-read-api-java) when running in GitLab CI, to eliminate HTTP 429 rate-limits from public registries. The change is gated behind two Gradle properties (mavenRepositoryProxy, gradlePluginProxy) that are only set in CI via .gitlab-ci.yml. Local builds with no property set are a strict no-op; the existing public registries (mavenCentral, gradlePluginPortal, google, jitpack) remain as fallbacks in every repositories block. Follows the same approach as DataDog/dd-trace-java#9351, targeting the Magic Mirror Depot URL directly.
448cdf6 to
13bffbc
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3452 +/- ##
===========================================
+ Coverage 72.05% 72.07% +0.02%
===========================================
Files 961 961
Lines 35399 35398 -1
Branches 5882 5882
===========================================
+ Hits 25506 25511 +5
- Misses 8274 8276 +2
+ Partials 1619 1611 -8 🚀 New features to boost your workflow:
|
4 participants
What and why
Routes Gradle dependency and plugin resolution through Datadog's internal Magic Mirror Depot (
depot-read-api-java) when running in GitLab CI, to eliminate HTTP 429 rate-limits from public registries (Maven Central, Gradle Plugin Portal).The change is gated behind two Gradle properties (
mavenRepositoryProxy,gradlePluginProxy) that are only set in CI via.gitlab-ci.yml. Local builds with no properties set are a strict no-op; the existing public registries (mavenCentral,gradlePluginPortal,google,jitpack) remain as fallbacks in everyrepositories { }block.Follows the same approach as DataDog/dd-trace-java#9351 and DataDog/dd-trace-java#9802 (which switched property injection from
gradle.propertiesfile writes toORG_GRADLE_PROJECT_*environment variables).What changes
CI configuration
.gitlab-ci.yml: declareMAVEN_REPOSITORY_PROXYandGRADLE_PLUGIN_PROXYenv vars pointing at the depot URL.ci/pipelines/default-pipeline.yml: add adefault.before_scriptthat exportsORG_GRADLE_PROJECT_mavenRepositoryProxyandORG_GRADLE_PROJECT_gradlePluginProxy. Gradle reads anyORG_GRADLE_PROJECT_<name>env var asproviders.gradleProperty("<name>"), and the env vars naturally inherit to child Gradle processes via the shell environment.How to verify
./gradlew :features:dd-sdk-android-session-replay-compose:assembleReleasewith cold cache; resolves entirely from public registries.providers.gradleProperty(...). Verified via a temporary--infodiagnostic on thetest:toolsjob that logged all repository URL hits (logs here) — depot served Maven Central artifacts, Google and Jitpack served their canonical content, no directrepo1.maven.orgorrepo.maven.apache.orgtraffic.hector.morilloprieto/RUM-15510-v2.